Skip to content

Add Secret Handshake Exercise#634

Merged
mk-mxp merged 3 commits intoexercism:mainfrom
tomasnorre:add-secret-handshake-exercise
Feb 23, 2024
Merged

Add Secret Handshake Exercise#634
mk-mxp merged 3 commits intoexercism:mainfrom
tomasnorre:add-secret-handshake-exercise

Conversation

@tomasnorre
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp added x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Feb 22, 2024
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very nice already. If you do not want to add some binary notation: I'm happy to merge it as it is, too.

Comment thread exercises/practice/secret-handshake/SecretHandshakeTest.php
Co-authored-by: mk-mxp <55182845+mk-mxp@users.noreply.github.com>
@mk-mxp
Copy link
Copy Markdown
Contributor

mk-mxp commented Feb 23, 2024

@tomasnorre Maybe a bit more binary notation here and there? Randomly choose test input, so we get a nice mixture of both notations.

@tomasnorre
Copy link
Copy Markdown
Contributor Author

@tomasnorre Maybe a bit more binary notation here and there? Randomly choose test input, so we get a nice mixture of both notations.

I can do that. Hold on ;)

Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! Very nice.

@mk-mxp mk-mxp merged commit 2b0ecd7 into exercism:main Feb 23, 2024
@tomasnorre tomasnorre deleted the add-secret-handshake-exercise branch February 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants