Skip to content

Add Rotational Cipher Exercise#635

Merged
mk-mxp merged 2 commits intoexercism:mainfrom
tomasnorre:add-rotational-cipher-exercise
Feb 23, 2024
Merged

Add Rotational Cipher Exercise#635
mk-mxp merged 2 commits intoexercism:mainfrom
tomasnorre:add-rotational-cipher-exercise

Conversation

@tomasnorre
Copy link
Copy Markdown
Contributor

@tomasnorre tomasnorre force-pushed the add-rotational-cipher-exercise branch from 48c768a to 3ecc79d Compare February 22, 2024 21:28
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! And such a high quality of your contribution. Your code is nice to read.

Comment thread exercises/practice/rotational-cipher/.docs/instructions.md
@tomasnorre tomasnorre requested a review from mk-mxp February 23, 2024 07:50
@mk-mxp mk-mxp merged commit 7bd7330 into exercism:main Feb 23, 2024
@mk-mxp
Copy link
Copy Markdown
Contributor

mk-mxp commented Feb 23, 2024

Thanks a lot for contributing! You must tell me, which AI you use to produce that good code so fast...

@tomasnorre
Copy link
Copy Markdown
Contributor Author

Thanks a lot for contributing! You must tell me, which AI you use to produce that good code so fast...

ChatGPT, it was that obvious. :) I'm taking existing exercises from other languages and convert the tests and example, and adjust to my liking. It's faster this way.

@tomasnorre tomasnorre deleted the add-rotational-cipher-exercise branch February 23, 2024 13:00
@tomasnorre
Copy link
Copy Markdown
Contributor Author

Not it's a matter of "score" on exercism, but is the "missing tags", the reason this got scored lower than the others?

@neenjaw
Copy link
Copy Markdown
Collaborator

neenjaw commented Feb 23, 2024

By default all prs are scored as a medium, I think mkmxp scored some of these as a large? Without tags they don't get attributed to a specific sub-category.

@tomasnorre
Copy link
Copy Markdown
Contributor Author

By default all prs are scored as a medium, I think mkmxp scored some of these as a large? Without tags they don't get attributed to a specific sub-category.

No Problem, thought it has something to do with the tagging, and you confirmed that.

@mk-mxp
Copy link
Copy Markdown
Contributor

mk-mxp commented Feb 23, 2024

@tomasnorre Yes, all my bad. Was too much in hurry this morning. Will take more time and be more cautious.

@neenjaw
Copy link
Copy Markdown
Collaborator

neenjaw commented Feb 23, 2024

Tags can be added retroactively and it will update.

@tomasnorre
Copy link
Copy Markdown
Contributor Author

@tomasnorre Yes, all my bad. Was too much in hurry this morning. Will take more time and be more cautious.

Not a huge deal, but must admit the gamification motivates me too :)

@mk-mxp mk-mxp added x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:size/large Large amount of work x:rep/large Large amount of reputation labels Feb 23, 2024
@mk-mxp
Copy link
Copy Markdown
Contributor

mk-mxp commented Feb 23, 2024

Thanks for the info, @neenjaw !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/create Work on something from scratch x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation x:size/large Large amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants