Add Two Bucket Exercise

[tomasnorre]

We didn't agree on this, either. But here it is. Feel a little like a rebel not following orders.

http://forum.exercism.org/t/implement-some-missing-php-exercises-for-48in24/9865/11

[mk-mxp]

We didn't agree on this, either. But here it is. Feel a little like a rebel not following orders.

Is that a good feeling to you? You do not have to apologize for the many useful work you contribute. You are welcome!

[tomasnorre]

We didn't agree on this, either. But here it is. Feel a little like a rebel not following orders.

Is that a good feeling to you? You do not have to apologize for the many useful work you contribute. You are welcome!

Am not feeling good or bad, just a feeling, that I'm not really following the normal process of asking before doing.

[mk-mxp]

Sorry, wrong selection.

[neenjaw]

This interface is an improvement from the last, but since we don't have a meaning for what the buckets mean before the solve method is called, I think we should take one of these two options:

// Option A

class TwoBucket
{
    // drop the constructor, class properties

    public function solve(int $sizeBucketOne, int $sizeBucketTwo, int $goal, string $startBucket)
    {
        // perform the solution for the parameters provided, return a solution object
    }
}

// or Option B

class TwoBucket
{
    public function __construct(int $sizeBucketOne, int $sizeBucketTwo, int $goal, string $startBucket)
    {
        // initialize and solve the solution, making the buckets available in getters
    }

    // drop the solve method
}

Currently we have an object that requires its public methods to be called in a specific order before it is considered valid -- this is a cumbersome pattern that shifts the burden of implementation to the consumers of this object to understand the inner state of the object to use it correctly rather than the object being the expert on itself.

[mk-mxp]

Thanks for pointing that out. It is inherently a procedural problem, "input, process, output". Which means, the only feasable way to implement it is just a single function or method call.

[tomasnorre]

I opt for option A. I like that approach more than having the logic in the constructor. For me, the constructor is for setting up the Class/Object, not doing any logic.

I think I'll manage to have it adjusted one of the following days, if neither of you opt against it.

[mk-mxp]

Thanks a lot for contributing! It took a bit longer to figure it out, but we are both learning about what's relevant for a good practice exercise.

[tomasnorre]

Thanks a lot for contributing! It took a bit longer to figure it out, but we are both learning about what's relevant for a good practice exercise.

You're welcome. It doesn't really matter how long it takes, as long as we keep the eye on the target and stay constructive in feedback and dialogue.

I really appreciate inputs from both of you @mk-mxp and @neenjaw.

I hope I can continue to bring quality work to the PHP track.