Add Eliuds Eggs exercise#639
Conversation
3e5cea5 to
f30e807
Compare
tomasnorre
left a comment
There was a problem hiding this comment.
LGTM, with few adjustments.
I personally think that would be helpful, I would appreciate information on that, to easier solve the exercise. |
b22dd93 to
6d28ec7
Compare
I did add some instructions in: https://github.com/exercism/php/pull/639/files#diff-1b8add07daeefcbb201624c607300ed14d8a926741b6a6d9562b7faa1c9b291f Do you think this is enough? I think the current should be enough for someone providing a working solution such as: $displayValue = 89;
$eggCount = (($displayValue & 0b00000001) > 0)
+ (($displayValue & 0b00000010) > 0)
+ (($displayValue & 0b00000100) > 0)
+ (($displayValue & 0b00001000) > 0)
+ (($displayValue & 0b00010000) > 0)
+ (($displayValue & 0b00100000) > 0)
+ (($displayValue & 0b01000000) > 0)
+ (($displayValue & 0b10000000) > 0);
// => 4 |
mk-mxp
left a comment
There was a problem hiding this comment.
Nice recursive solution to the problem. Add the UUIDs if you want to, but we can merge it as is.
I think that is fine. One does not need much knowledge about binary operators, the PHP manual page will be enough. |
6d28ec7 to
b2d7f72
Compare
b2d7f72 to
f4f9b26
Compare
Uh oh!
There was an error while loading. Please reload this page.