Improve contributor experience#654
Merged
mk-mxp merged 12 commits intoexercism:mainfrom Mar 7, 2024
Merged
Conversation
mk-mxp
added
x:action/improve
mk-mxp
force-pushed
the
improve-contributor-experience
branch
from
e26596a to
9ea1692
Compare
Contributor
homersimpsons
left a comment
homersimpsons
left a comment
There was a problem hiding this comment.
I think the change regarding configlet are debatable. But let's do them and see if there is any negative feedback.
mk-mxp
force-pushed
the
improve-contributor-experience
branch
from
9ea1692 to
845574c
Compare
This might be the problem why it didn't work as expected. No 'composer.lock' -> 'composer update' is run.
mk-mxp
force-pushed
the
improve-contributor-experience
branch
from
845574c to
59aab70
Compare
homersimpsons
approved these changes
Mar 5, 2024
tomasnorre
pushed a commit
to tomasnorre/exercism-php
that referenced
this pull request
May 7, 2024
* Add "configlet:fmt" command * Combine all CI tests to command "ci" * Install / update configlet with composer packages * Remove PHP 7.4 from 'composer.json' * Do not run composer scripts in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #620 and fixes issues with the GitHub actions workflow for PHPCS linting:
strategykey, it must provide amatrixin that.