Skip to content

sync diamond#832

Merged
mk-mxp merged 1 commit intoexercism:mainfrom
tomasnorre:sync-diamond
Oct 30, 2024
Merged

sync diamond#832
mk-mxp merged 1 commit intoexercism:mainfrom
tomasnorre:sync-diamond

Conversation

@tomasnorre
Copy link
Copy Markdown
Contributor

Resolves #826

@github-actions
Copy link
Copy Markdown

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@tomasnorre
Copy link
Copy Markdown
Contributor Author

This is not completely done, as I wasn't aware how to deal with the change of function diamond() to rows() according to the https://github.com/exercism/problem-specifications/blob/main/exercises/diamond/canonical-data.json

@mk-mxp mk-mxp added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Oct 30, 2024
Copy link
Copy Markdown
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@mk-mxp mk-mxp merged commit e93178d into exercism:main Oct 30, 2024
@tomasnorre tomasnorre deleted the sync-diamond branch October 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#48in24: diamond 2024-12-03

2 participants