Deprecate deprecated exercises from problem specifications#834
Merged
mk-mxp merged 2 commits intoexercism:mainfrom Oct 31, 2024
Merged
Deprecate deprecated exercises from problem specifications#834mk-mxp merged 2 commits intoexercism:mainfrom
mk-mxp merged 2 commits intoexercism:mainfrom
Conversation
Contributor
|
There's nothing wrong with the checking file, I think. I only think about the location. Maybe put it into Adding it to the PHP CodeSniffer exclusion list here should remove the strict types header requirement. |
mk-mxp
approved these changes
Oct 31, 2024
Contributor
mk-mxp
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for solving this problem!
Contributor
Author
You're welcome. Only happy to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #813
I know the
checkDeprecatedExercisesisn't super nice, but it was the fastest way I knew to get inform about which exercises was deprecated.I can look into the
configletrepository, to see if I can incorporate the functionally there.Output from script: