replace 'problems' key with 'exercises' in config.json#16
Merged
kytrinyx merged 1 commit intoexercism:masterfrom Jun 2, 2017
Merged
replace 'problems' key with 'exercises' in config.json#16kytrinyx merged 1 commit intoexercism:masterfrom
kytrinyx merged 1 commit intoexercism:masterfrom
Conversation
Contributor
Author
|
I forgot to point out that as of exercism/x-api#137, it is safe to remove |
petertseng
added a commit
to exercism/problem-specifications
that referenced
this pull request
Jan 17, 2017
In various tracks, I sometimes see contributors forget to do this, and
perhaps one cause is that the requirement isn't mentioned here (various
tracks link to this document to explain how to port an exercise to their
track).
Luckily, this gets caught by configlet (assuming the track is running
Travis CI and hasn't removed configlet), but it would be good to let
contributors to know of this up front.
Decision: This text explcitly mentions the `"exercises"` key, rather
than the deprecated `"problems"` key.
The following procedure:
gem install trackler --ignore-dependencies
# substitute your Ruby version for $RUBY_VERSION
grep -L exercises ~/.gem/ruby/$RUBY_VERSION/gems/trackler-2.0.6.10/tracks/*/config.json
says that only two tracks lack the `exercises` key: Ceylon and PL/SQL
* a PR exercism/plsql#16 is open for PL/SQL
* a PR exercism/ceylon#8 has already been
merged in Ceylon and will go out in the next Trackler update.
Therefore, it almost certainly safe to use the `exercises` key!
One weakness is that this text doesn't explicitly mention the `slug` or
`difficulty` or `topics` keys for each entry in the `exercises` array.
This weakness is currently mitigated by the fact that active languages
should have many examples to go off of. The only time where there are no
examples will be when starting a brand-new track.
Member
|
I'm sorry I missed this. Thank you so much for taking the time to fix it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #15