alphametics: Update json for new "input" policy#1035
Merged
ErikSchierboom merged 2 commits intoexercism:masterfrom Jan 5, 2018
Merged
alphametics: Update json for new "input" policy#1035ErikSchierboom merged 2 commits intoexercism:masterfrom
ErikSchierboom merged 2 commits intoexercism:masterfrom
Conversation
rpottsoh
previously approved these changes
Dec 15, 2017
Member
Contributor
Author
Stargator
force-pushed
the
input-alphametics
branch
2 times, most recently
from
b508b50 to
9abf559
Compare
Contributor
Author
|
Updated to reflect recent changes |
rpottsoh
previously requested changes
Dec 19, 2017
Stargator
force-pushed
the
input-alphametics
branch
from
9abf559 to
dcc6a4e
Compare
ErikSchierboom
requested changes
Jan 4, 2018
Member
ErikSchierboom
left a comment
ErikSchierboom
left a comment
There was a problem hiding this comment.
Could you also convert the last test case (with the many addends) to the new structure? You might want to rebase onto the latest master first.
rpottsoh
dismissed
their stale review
Thanks for making the changes I requested, but @ErikSchierboom's requested changes trump my approval, so I am dismissing my review.
rpottsoh
force-pushed
the
input-alphametics
branch
2 times, most recently
from
4a795aa to
dcc6a4e
Compare
rpottsoh
force-pushed
the
input-alphametics
branch
from
dcc6a4e to
d96eb80
Compare
Member
|
@ErikSchierboom I have managed to rebase.... |
rpottsoh
approved these changes
Jan 5, 2018
ErikSchierboom
approved these changes
Jan 5, 2018
Member
|
@rpottsoh @Stargator Thanks for this! |
petertseng
added a commit
to exercism/haskell
that referenced
this pull request
Jan 11, 2018
1.1.0: new test exercism/problem-specifications#1024 1.1.1: description exercism/problem-specifications#1045 1.2.0: input object exercism/problem-specifications#1035
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#996 Updated the schema for canonical data. So I am updating the exercise's json to reflect the change.