DO NOT MERGE: mistakenly ask for new schema for an improperly-converted JSON file#1073
Closed
petertseng wants to merge 4 commits intoexercism:masterfrom
petertseng:ci-new-schema-breakit
Closed
DO NOT MERGE: mistakenly ask for new schema for an improperly-converted JSON file#1073petertseng wants to merge 4 commits intoexercism:masterfrom petertseng:ci-new-schema-breakit
petertseng wants to merge 4 commits intoexercism:masterfrom
petertseng:ci-new-schema-breakit
Conversation
Member
Author
|
Hooray, it failed. |
Derived from the list of invalid exercises listed in: #998 (comment)
This schema was proposed and accepted in #996
If it is present, use the old schema, else use the new schema. This plan is proposed in: #998 Its merits are that it allows us to: * Track progress by simply counting number of USE_OLD_SCHEMA file. * Verify, as each PR is made, that each JSON file intending to use new schema does in fact validate. * Otherwise we have to manually run a schema check at periodic intervals. * Keep compatibility with old schema, to support moving over one file at a time instead of all at once. Note that old-schema.json is the same canonical-schema.json as is currently on master. The intention is that when all exercises use the new schema, **this commit can/should be reverted** and then all exercises will in fact use the new schema, which will replace the old completely.
USE_OLD_SCHEMA file removed, BUT not properly converted to new schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If #1072 was done correctly, this must fail.