circular-buffer: Apply new "input" policy#1186
Merged
ErikSchierboom merged 2 commits intoexercism:masterfrom Feb 13, 2018
Merged
circular-buffer: Apply new "input" policy#1186ErikSchierboom merged 2 commits intoexercism:masterfrom
ErikSchierboom merged 2 commits intoexercism:masterfrom
Conversation
ErikSchierboom
force-pushed
the
circular-buffer-input
branch
from
bda0b99 to
7b57d4f
Compare
petertseng
reviewed
Feb 13, 2018
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
https://github.com/petertseng/exercism-problem-specifications/blob/verify/exercises/circular-buffer/verify.rb tells me this is correct, and git log -p -w looks reasonable. Only reason I don't Approve (in the GitHub sense of the word) is the newline at the end of the file which got removed.
Member
Author
|
Newline added. Please squash when merging. |
petertseng
approved these changes
Feb 13, 2018
petertseng
added a commit
to exercism/rust
that referenced
this pull request
Nov 18, 2018
The tests are the same as the initial unversioned version of canonical-data: exercism/problem-specifications#488 This is because all subsequent changes did not change test content: 1.0.0 (formatting change only): exercism/problem-specifications#681 1.0.1 (clarify overwrite): exercism/problem-specifications#892 1.1.0 (move inputs to `input` object): exercism/problem-specifications#1186 The Rust track already had most of the tests; these mostly add some clarity around `clear` and addds a test for an `overwrite` following a `read`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #996.