react: Test callbacks on multiple cells#1197
Merged
petertseng merged 1 commit intoexercism:masterfrom Apr 13, 2018
petertseng:react-multi
Merged
react: Test callbacks on multiple cells#1197petertseng merged 1 commit intoexercism:masterfrom petertseng:react-multi
petertseng merged 1 commit intoexercism:masterfrom
petertseng:react-multi
Conversation
react 1.3.0 Consider an implementation that stops looking for cells to fire callbacks on after it has found any single cell that has callbacks. That would fail this test.
Member
Author
|
If #1197 is merged before #1196, the version number progression will be 1.2.0 -> 1.3.0 -> 2.0.0. It does not matter to me which path is taken. In the absence of other feedback, I will arrange so that the final version is 2.0.0, but if there is a large disparity in time of Approval (in the GitHub sense) of the two PRs, I will of course take the appropriate path dictated by those Approvals. |
ErikSchierboom
approved these changes
Apr 13, 2018
Member
|
@petertseng Is this ready to be merged? |
Member
Author
Yes. |
Member
Author
|
Thank you for reviewing! |
petertseng
added a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Apr 13, 2018
2.0.0: Combine expectCallbacks into exercism/problem-specifications#1196 was already performed pre-emptively in exercism#63 1.3.0: Multiple cells (the actual change here): exercism/problem-specifications#1197
petertseng
added a commit
to exercism/ceylon
that referenced
this pull request
Apr 13, 2018
2.0.0: Combine expectCallbacks into setvalue: exercism/problem-specifications#1196 was already performed pre-emptively in #63 1.3.0: Multiple cells (the actual change here): exercism/problem-specifications#1197
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react 1.3.0
Consider an implementation that stops looking for cells to fire
callbacks on after it has found any single cell that has callbacks. That
would fail this test.