Skip to content

isbn-verifier: adding test case for 0 < length < 10 #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
petertseng merged 1 commit into from
Apr 10, 2018
Merged

isbn-verifier: adding test case for 0 < length < 10 #1221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion exercises/isbn-verifier/canonical-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"exercise": "isbn-verifier",
"version": "2.3.0",
"version": "2.4.0",
"comments": [
"An expected value of true indicates a valid ISBN-10, ",
"whereas false means the ISBN-10 is invalid."
Expand Down Expand Up @@ -117,6 +117,14 @@
"isbn": ""
},
"expected": false
},
{
"description": "input is 9 characters",
"property": "isValid",
"input": {
"isbn": "134456729"
Copy link
Copy Markdown
Member

@petertseng petertseng Apr 10, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation interesting, but since we are not enforcing it automatically, my only argument is "it should be the same so that it is consistent, which will maybe make it easier to read"

},
"expected": false
}
]
}