isbn-verifier: add a test case that would be accepted by an implementation where an invalid character is simply dropped#1245
Merged
cmccandless merged 3 commits intomasterfrom May 26, 2018
Conversation
…ation where an invalid character is simply dropped Closes #1218
RE: @rpottsoh review
Member
|
The math checks out. This should be squashed when it is merged... And I see that the version has been bumped while I type this. 👍 |
rpottsoh
approved these changes
May 25, 2018
petertseng
approved these changes
May 26, 2018
Member
There was a problem hiding this comment.
Great, I just confirmed that the implementation at https://github.com/petertseng/exercism-problem-specifications/blob/verify/exercises/isbn-verifier/verify.rb#L95-L103 accepts this new case.
I agree that it should be squashed when merging.
Since submitter can merge, I am assuming it is not my responsibility to merge.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1218