Bob: Fix grammatical error in testdata#1319
Merged
rpottsoh merged 1 commit intoexercism:masterfrom Sep 10, 2018
sshine:master
Merged
Bob: Fix grammatical error in testdata#1319rpottsoh merged 1 commit intoexercism:masterfrom sshine:master
rpottsoh merged 1 commit intoexercism:masterfrom
sshine:master
Conversation
rpottsoh
changed the title
rpottsoh
requested changes
Sep 8, 2018
Member
rpottsoh
left a comment
rpottsoh
left a comment
There was a problem hiding this comment.
"version" needs to be updated. See README.md of this repo for more information.
Member
|
Your proposed change to |
Contributor
Author
|
Thank you for letting me know. I've bumped the MINOR version. |
rpottsoh
approved these changes
Sep 8, 2018
Member
|
This PR should sit for at least another day to allow time for anyone that might want to comment. To whomever merges this, the PR should be squashed as it is merged. |
In the Bob exercise it says:
> Bob's conversational partner is a purist when it comes to written
> communication and always follows normal rules regarding sentence
> punctuation in English.
But in the unit test the following input is fed to `responseFor`:
"\nDoes this cryogenic chamber make me look fat?\nno"
This is a rhetorical question, and by the expected value, this is deemed
to not be an actual question, which is very reasonable. But if Bob's
conversational partner is a punctuation purist, it should at least end
with a period.
I found this when exercising the Haskell track and wanting to grab the
last character that `isPunctuation`, but had to go with `not . isSpace`
(like the reference solution). But this really sounds wrong when I think
about it: I actually want the last punctuation character and am allowed
to assume "normal rules".
Making this change will not render `not . isSpace` solutions in the
Haskell track incorrect. I don't know what the implications are in other
language tracks that use this test case, and I don't know how to test
this.
Bump MINOR version of bob
Changing 'no' into 'No.' should be backwards-compatible.
Member
|
@sshine thanks for taking the time to submit this PR and helping out Bob. 👍 |
petertseng
pushed a commit
to exercism/haskell
that referenced
this pull request
Sep 12, 2018
In the Bob exercise it says:
> Bob's conversational partner is a purist when it comes to written
> communication and always follows normal rules regarding sentence
> punctuation in English.
But in the unit test the following input is fed to `responseFor`:
"\nDoes this cryogenic chamber make me look fat?\nno"
This is a rhetorical question, and by the expected value, this is deemed
to not be an actual question, which is very reasonable. But if Bob's
conversational partner is a punctuation purist, it should at least be
"no." with the period.
I found this by wanting to grab the last character that `isPunctuation`,
but had to go with `not . isSpace` (like the reference solution). But
this really sounds wrong when I think about it: I actually want the last
punctuation character and am allowed to assume "normal rules".
Making this change will not render `not . isSpace` solutions wrong.
Bump test version to 1.4.0.7.
exercism/problem-specifications#1319
sshine
added a commit
to exercism/sml
that referenced
this pull request
Oct 9, 2018
This includes: - 1.0.0 -> 1.1.0: "Calm down, I know what I'm doing!" in [1]. - 1.1.0 -> 1.2.0: No-op in [2] - 1.2.0 -> 1.2.1: "no letters" in [3]. - 1.2.1 -> 1.3.0: "I HATE THE DMV" in [4]. - 1.3.0 -> 1.4.0: Grammatical error in testdata in [5]. [1]: exercism/problem-specifications#1025 [2]: exercism/problem-specifications#1056 [3]: exercism/problem-specifications#1282 [4]: exercism/problem-specifications#1293 [5]: exercism/problem-specifications#1319
ZapAnton
added a commit
to ZapAnton/rust
that referenced
this pull request
Nov 20, 2018
Relevant PRs: - exercism/problem-specifications#1282 - exercism/problem-specifications#1293 - exercism/problem-specifications#1319 Appart from the new tests, some old tests were renamed / got their input value modified.
This was referenced Sep 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Bob exercise it says:
But in the unit test the following input is fed to
responseFor:This is a rhetorical question, and by the expected value, this is deemed
to not be an actual question, which is very reasonable. But if Bob's
conversational partner is a punctuation purist, it should at least end
with a period.
I found this when exercising the Haskell track and wanting to grab the
last character that
isPunctuation, but had to go withnot . isSpace(like the reference solution). But this really sounds wrong when I think
about it: I actually want the last punctuation character and am allowed
to assume "normal rules".
Making this change will not render
not . isSpacesolutions in theHaskell track incorrect. I don't know what the implications are in other
language tracks that use this test case, and I don't know how to test
this.