leap 1.4.0: Add negative test: year divisible by 200, not divisible by 400#1359
Merged
sshine merged 1 commit intoexercism:masterfrom Oct 9, 2018
sshine:leap-1.4.0
Merged
leap 1.4.0: Add negative test: year divisible by 200, not divisible by 400#1359sshine merged 1 commit intoexercism:masterfrom sshine:leap-1.4.0
sshine merged 1 commit intoexercism:masterfrom
sshine:leap-1.4.0
Conversation
petertseng
approved these changes
Oct 9, 2018
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
It does seem this is necessary. another alternative would have to change the 2100 to an 1800, but the purpose of each case may become unclear if each case starts to test too many things!
Someone thought they could write `year mod 200 = 0`. Test didn't fail.
petertseng
pushed a commit
to exercism/haskell
that referenced
this pull request
Oct 9, 2018
…y 400 (#733) Addresses exercism/problem-specifications#1359 Previously, an implementation of `year mod 200 = 0` didn't fail!
matthewmorgan
pushed a commit
to exercism/javascript
that referenced
this pull request
Oct 20, 2018
petertseng
pushed a commit
to petertseng/exercism-ceylon
that referenced
this pull request
Nov 1, 2018
Someone thought they could write `year mod 200 = 0`. Test didn't fail. exercism/problem-specifications#1359
ZapAnton
added a commit
to ZapAnton/rust
that referenced
this pull request
Nov 19, 2018
ZapAnton
added a commit
to ZapAnton/rust
that referenced
this pull request
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone thought they could write
year mod 200 = 0. Test didn't fail.