two-fer: clarifying specification#1374
two-fer: clarifying specification#1374rpottsoh merged 1 commit intoexercism:masterfrom uzilan:twofer
Conversation
…rough and by giving some examples
|
Only mentors for the track you are considering will be able to view the link you have posted. Please consider posting the code into a comment so we all can see it. |
|
I would say that this change clarifies the specification, but doesn't simplify the explanation. It was pretty simple already. 😄 |
|
Here's the example solution I was referring to: class Twofer {
String twofer(String name) {
if (name == "Alice") {
name = "Alice";
} else if (name == "Bob") {
name = "Bob";
} else {
name = "you";
}
return "One for " + name + ", one for me.";
}
} |
rpottsoh
left a comment
There was a problem hiding this comment.
I like the nod to Douglas Adams. 👍
|
I was consodering Slartibartfast but it was slightly too long :) |
ErikSchierboom
left a comment
There was a problem hiding this comment.
I have mentored this exercise lots of times and have never seen anyone do this, but it sure can't be bad to add this :)
|
I am going to go ahead and merge this. Thanks @uzilan for making these improvements to the README. |
|
Thank you too. So, how do the different tracks get the updated version? Do we need a PR in every track? |
|
It is up to each track to update their README for this exercise. Hopefully the track maintainers are monitoring this REPO and have noticed this PR merging. The tracks applying the changes you have submitted is completely voluntary. The tracks are not required to follow what happens in this repo to the letter, but most do. Others may add their own twists to the exercises that work well with their particular language. If there is a particular track where you would like to see you changes incorporated I suggest creating an issue in that track's repo and site this PR in your comment. |
As a mentor, I often see solutions of two-fer where the mentee simply didn't understand the exercise. Sometimes they just check for the names Alice and Bob and return a string with these names. If the given name is neither, they return the string with you instead. See for example here: https://exercism.io/mentor/solutions/93be9a7ec7014a38920063a683963ffa
I believe this problem stem from the fact that the description is unclear. This PR contains my suggestion for making it a bit clearer by being more thorough and by giving some examples.