Rename retree into satellite (fixes #1451)#1478
Merged
sshine merged 2 commits intoexercism:masterfrom Mar 14, 2019
sshine:rename-retree-into-sattelite
Merged
Rename retree into satellite (fixes #1451)#1478sshine merged 2 commits intoexercism:masterfrom sshine:rename-retree-into-sattelite
sshine merged 2 commits intoexercism:masterfrom
sshine:rename-retree-into-sattelite
Conversation
cmccandless
suggested changes
Mar 13, 2019
Contributor
cmccandless
left a comment
cmccandless
left a comment
There was a problem hiding this comment.
The PR title and new directory will also need to be renamed from exercises/sattellite to exercises/satellite.
| { | ||
| "exercise": "retree", | ||
| "exercise": "sattelite", | ||
| "version": "1.0.0", |
Contributor
There was a problem hiding this comment.
Should we modify the version here?
Contributor
Author
There was a problem hiding this comment.
I think so.
MAJOR changes should be expected to break even well-behaved test generators.
sshine
changed the title
Contributor
Author
|
Darn. That's how you spell it in Danish! I've fixed the typo everywhere but in the name of my feature branch. (Not sure how to do that without abandoning the PR.) |
cmccandless
approved these changes
Mar 14, 2019
Contributor
I wouldn't worry about it.
I'm not sure it's possible. |
Average-user
pushed a commit
to exercism/prolog
that referenced
this pull request
Mar 15, 2019
This commit renames the 'retree' exercise into 'satellite': - Decision: exercism/problem-specifications#1451 - PR: exercism/problem-specifications#1478
petertseng
added a commit
that referenced
this pull request
Apr 15, 2019
I rehash my prior allegations of #693 below: I contend that having the word `push` in the name unnecessarily biases the solution space toward solutions that use a stack data structure (has a *push* operation) or a *push*-down automaton, rather than other solutions not using either of these two. We have heard a principle that we want to name exercises by their story, not by what they teach: #1451 (comment) The story here is about matching brackets, so I posit that that serves as the name we want. I have changed the major version number, as was done in the retree->satellite rename, even though I do not feel strongly about whether that should be necessary: #1478 As we have gained experience in the rename of retree, we see that problem-specifications is free to rename exercises at any point, without waiting for all tracks to follow suit. Of course, this operation should not be performed lightly since it causes churn in the 31 (*thirty-one*) tracks implementing this exercise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following @petertseng's suggested workflow in #1451 (thanks for providing this, by the way!):
Send a PR to https://github.com/exercism/website-icons/tree/master/exercisesThe icon for "retree" has not been merged yet, so instead, ping Glyph for new exercise: satellite website-icons#22 and have them name this icon"sattelite""satellite" instead of "retree".exercisesdirectory and inconfig.json!Rename mentor notesNo mentor notes for exercise yet.This PR is mergeable before these checkboxes have been marked.
Question: Should the test version be bumped when the exercise name changes?