Skip to content

Improve anagram problem statement#1529

Merged
SleeplessByte merged 1 commit intoexercism:masterfrom
gris:improve-anagram-definition
Jun 10, 2019
Merged

Improve anagram problem statement#1529
SleeplessByte merged 1 commit intoexercism:masterfrom
gris:improve-anagram-definition

Conversation

@gris
Copy link
Copy Markdown
Contributor

@gris gris commented Jun 10, 2019

  • Add definition of anagram
  • Improve readability

Fixes #1528

Copy link
Copy Markdown
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think that the technical term sublist should remain.

Perhaps: Given a word and a list of candidates, select the sublist of anagrams of the given word.

@gris
Copy link
Copy Markdown
Contributor Author

gris commented Jun 10, 2019

Thanks! It makes sense to leave sublist there indeed.

Copy link
Copy Markdown
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for three ✅

However, have you seen this comment: https://github.com/joaomarcosgris/problem-specifications/commit/c7809eb1e09ff0bb40fad69f7fb5ee70a72ceead#commitcomment-33870374 @joaomarcosgris ? I think it makes sense what Maud says, but you can decide as far as I'm concerned.

cc @F3PiX @ErikSchierboom @kotp

@emcoding
Copy link
Copy Markdown
Contributor

but you can decide as far as I'm concerned.
I agree :-)

I can't add a review, but you may count me as #3 @SleeplessByte

kotp
kotp previously requested changes Jun 10, 2019
Copy link
Copy Markdown
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the wording, it suggests that the same word is not an anagram, as it must be a rearrangement of letters.

Comment thread exercises/anagram/description.md Outdated
- Add definition of anagram
- Improve readability

Fixes #1528
@SleeplessByte
Copy link
Copy Markdown
Member

Thank you @F3PiX , @kotp and @rpottsoh for the quick reviews!

This is perfect @joaomarcosgris ❤️

@SleeplessByte SleeplessByte merged commit c7a7bbc into exercism:master Jun 10, 2019
@gris gris deleted the improve-anagram-definition branch June 10, 2019 22:35
petertseng pushed a commit to stringparser/rust that referenced this pull request Jun 25, 2019
petertseng pushed a commit to petertseng/exercism-ceylon that referenced this pull request Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anagram: improve description to define what is an anagram

5 participants