robot-name description: singular "robot"#1599
Merged
yawpitch merged 1 commit intoexercism:masterfrom Oct 6, 2019
cxw42:robot-name
Merged
robot-name description: singular "robot"#1599yawpitch merged 1 commit intoexercism:masterfrom cxw42:robot-name
yawpitch merged 1 commit intoexercism:masterfrom
cxw42:robot-name
Conversation
Use singular forms consistently throughout robot-name/description.md
yawpitch
approved these changes
Oct 6, 2019
Contributor
yawpitch
left a comment
yawpitch
left a comment
There was a problem hiding this comment.
Arguably most native English speakers would have no trouble using the original form -- the implication is that all robots (plural) end up with their own (singular) name assignment -- however I can see how this copy change would improve readability for people without English esoteric knowledge, so I approve.
Contributor
|
Thanks for the contribution! |
workingjubilee
added a commit
to workingjubilee/exercism-rust
that referenced
this pull request
Oct 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on exercism/perl5#328, I noticed that the description of robot-name mixed singular and plural. This PR changes robot-name/description.md to use singular forms consistently throughout. I also changed "boot up" to "turn on" in hopes of making it easier for non-native English speakers to understand the text.
This is my first contribution to this project - thank you for considering this PR!