fix: Remove trailing spaces#1627
fix: Remove trailing spaces#1627rpottsoh merged 1 commit intoexercism:masterfrom ffflorian:fix/trailing-spaces
Conversation
NobbZ
left a comment
NobbZ
left a comment
There was a problem hiding this comment.
Also in my opinion, canonical data hasn't changed, we should find a way to get in the whitespace repaired version without bumping...
| ||_||_| | ||
| ||_| _| | ||
|
|
There was a problem hiding this comment.
The whitespace in this code block is significant and not allowed to be removed
There was a problem hiding this comment.
What about changing it to this?
_ _ #
| _| _| #
||_ _| #
# (blank fourth row)
There was a problem hiding this comment.
With literal double crosses?
I think that would lead to similar discussion we had on another exercise where a border was drawn in the examples for visual clarification but not in the test suits for easier programmatic access... I think it was the minesweeper exercise.
Just let the whitespace where it belongs and don't add arbitrary characters which could be misinterpreted
There was a problem hiding this comment.
Alright. I reverted the changes to this file.
|
I have updated the initial comment. These changes may now be merged without the requirement to bump versions. The version bumps should be reversed. |
|
@ffflorian please include the statement |
Done, it works :) Just waiting for an answer from @NobbZ. |
I have confirmed that no JSON version change is needed
|
Happy New Year @NobbZ! I think @ffflorian has addressed both of the issues we had. What do you think? |
3 participants
This PR will remove trailing spaces in all files. Best viewed without whitespace changes.