Pangram: check case insensitive behavior#1660
Merged
SleeplessByte merged 3 commits intomainfrom Dec 10, 2021
Merged
Conversation
ErikSchierboom
force-pushed
the
1658-redo
branch
from
8b2f405 to
81146d3
Compare
Member
|
I've rebased this on the latest main and made one change, inspired by #1658 (comment): removing the second test case. CC @exercism/reviewers |
petertseng
approved these changes
Dec 10, 2021
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
I'm not huge on the necessity of this case, because supposedly case 2577bf54-83c8-402d-a64b-a2c0f7bb213a "case insensitive" already handles it.
$ ruby -e 'p ("the quick brown fox jumps over with lazy FX".chars - [" "]).uniq.size'
26
But, this is certainly a simpler and easier-to-understand way of expressing the same thing. Maybe it could even go before case 2577bf54-83c8-402d-a64b-a2c0f7bb213a "case insensitive" ...
ee7
reviewed
Dec 10, 2021
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
petertseng
approved these changes
Dec 10, 2021
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
I think they test the same thing. Replacing seems a fine idea.
SleeplessByte
approved these changes
Dec 10, 2021
ee7
reviewed
Dec 10, 2021
Co-authored-by: ee7 <45465154+ee7@users.noreply.github.com>
ee7
approved these changes
Dec 10, 2021
Member
|
Thanks all! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-opening of #1658