Improve descriptions to make sense per #1769#1777
Conversation
ErikSchierboom
left a comment
There was a problem hiding this comment.
@wolf99 I completely support these changes. They nicely follow our documentation that still says that the description is immutable. We've had some discussion on that in another issue (do you remember which issue @SleeplessByte?) and the conclusion there is that changing the description is fine too. Could you update the PR accordingly? I'll submit a different PR to update the documentation.
Is in the review comments on #1747 I believe. I will update my PR per your suggestion this evening then. |
2a337b2 to
d5c121b
Compare
| { | ||
| "uuid": "d5b283d4-455d-4e68-aacf-add6c4b51915", | ||
| "description": "50 is a single L", | ||
| "description": "59 is a single LIX", |
There was a problem hiding this comment.
Do we need the is a single bit in the description? It looks like it was removed from other test cases.
There was a problem hiding this comment.
Whoops, I missed this in the update.
Well caught Erik
Fixes #1769
There were cases where the descriptions where the data did not numerically match the descriptions, such as
There is a slight semantic difference between 2 and 3 if you consider that what this case is testing is not just explicitly that 1024 is MXXIV, but that absent any other test to the effect it also implicitly tests that 1000 is M as the original description states.
I chose 2 as it accurately describes what the test is doing, but 3 is probably as valid a change