Rename canonical-schema to canonical-data.schema.json#1908
Merged
ErikSchierboom merged 1 commit intomainfrom Jan 11, 2022
Merged
Rename canonical-schema to canonical-data.schema.json#1908ErikSchierboom merged 1 commit intomainfrom
ErikSchierboom merged 1 commit intomainfrom
Conversation
ErikSchierboom
force-pushed
the
rename-schema
branch
from
fda8926 to
a1198be
Compare
SaschaMann
approved these changes
Jan 7, 2022
junedev
approved these changes
Jan 7, 2022
BethanyG
approved these changes
Jan 7, 2022
wolf99
approved these changes
Jan 8, 2022
Member
Author
|
@iHiD Could you take a look? We need an exercism/maintainers-admin approval. |
ErikSchierboom
force-pushed
the
rename-schema
branch
from
a1198be to
27d4109
Compare
iHiD
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While going over old issues, I came across #700
That issue suggest to rename
canonical-schema.jsontocanonical-data.schema.json, which is a sensible change I feel.Therefore, this PR updates the filename as suggested.
Closes #700