auto-format portions of some JSON files#1967
Merged
SaschaMann merged 1 commit intoexercism:mainfrom Mar 4, 2022
Merged
Conversation
this commit was made by having prettier format these files and committing portions of the changes. For now we want prettier to continue to ignore these files, but eventually the plan would be to use prettier but to reformat specific portions. The portions in this commit are *not* the portions we would want to reformat, so for these specific portions we are satisfied to accept prettier's changes.
ErikSchierboom
approved these changes
Feb 17, 2022
Member
Author
|
I changed my mind about that, since that isn't a change that prettier makes. |
petertseng
force-pushed
the
format-partial
branch
2 times, most recently
from
a973058 to
234cc7a
Compare
SaschaMann
approved these changes
Feb 19, 2022
SaschaMann
reviewed
Feb 19, 2022
Comment on lines
+22
to
+26
| "territory": [ | ||
| [0, 0], | ||
| [0, 1], | ||
| [1, 0] | ||
| ] |
Contributor
There was a problem hiding this comment.
I'm not sure if this is necessarily better than the single-line versions but I'm not objecting to it either.
Member
|
Requesting a review from @exercism/reviewers |
kotp
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this commit was made by having prettier format these files and
committing portions of the changes.
For now we want prettier to continue to ignore these files, but
eventually the plan would be to use prettier but to reformat specific
portions.
The portions in this commit are not the portions we would want to
reformat, so for these specific portions we are satisfied to accept
prettier's changes.