allergies: format#1978
Merged
SaschaMann merged 1 commit intoexercism:mainfrom Mar 4, 2022
Merged
Conversation
race condition between "Exercise allergies test case" exercism#1969 and "allow prettier to format more files" exercism#1966 Since this file is now being formatted by prettier, the test case added in the latter PR must be formatted according to prettier. Otherwise, as will be observable from any PR after exercism#1966, CI fails on main. There are alternate approaches, such as directing format-array to always format `expected` with one item on each line, but it doesn't seem like this is particular important for the `allergies` exercise.
ErikSchierboom
approved these changes
Mar 4, 2022
angelikatyborska
approved these changes
Mar 4, 2022
SaschaMann
approved these changes
Mar 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
race condition between
"Exercise allergies test case"
#1969
and
"allow prettier to format more files"
#1966
Since this file is now being formatted by prettier, the test case added
in the latter PR must be formatted according to prettier.
Otherwise, as will be observable from any PR after
#1966, CI fails
on main.
There are alternate approaches, such as directing format-array to always
format
expectedwith one item on each line, but it doesn't seem likethis is particular important for the
allergiesexercise.