Update queen-attack test expectations#213
Conversation
|
This looks good to me. Would you mind updating the commit message to have |
| "position": "(1,1)" | ||
| }, | ||
| "expected": false | ||
| "expected": true |
There was a problem hiding this comment.
I believe the coordinates will need updating here if we want this to be true - (2, 4) can't attack (1, 1)
|
You'd think it would be simple to write a dang json file. Apparently not. Fixing those two errors that @petertseng spotted. |
IanWhitney
force-pushed
the
fix_queen_attack
branch
from
e559c1b to
cfa6a33
Compare
|
Ok. All diagonal tests now look good to me. |
|
Could you check real quick whether the change got pushed right? Still looks the same to me |
IanWhitney
force-pushed
the
fix_queen_attack
branch
from
cfa6a33 to
55f4e7a
Compare
|
Add Git to the things I can't get right today. |
|
@IanWhitney -- would you mind tweaking the commit subject line? It sounds like you're having a chaotic day, and I'm happy to amend the commit message if you've got too much stuff going on. Just say the word. |
|
OK from me on the json content, so it'll be ready to go when getting the commit message sorted. |
IanWhitney
force-pushed
the
fix_queen_attack
branch
from
55f4e7a to
ce7533b
Compare
|
Commit message changed. It's not that today was busy, but I'm traveling tomorrow. After that I'll be back at work and without these nice 3-4 hour stretches to think about test ordering, etc. |
IanWhitney
changed the title
|
Thanks! Good luck with travel (I know how that can go!) |
…erator Added rna_transcription test generator
4 participants
Fixing my copy & paste errors that @petertseng noticed in #211