Skip to content

Banish the smokers from the zebra puzzle#2459

Merged
IsaacG merged 1 commit intoexercism:mainfrom
glennj:zebra-edits
Jun 25, 2024
Merged

Banish the smokers from the zebra puzzle#2459
IsaacG merged 1 commit intoexercism:mainfrom
glennj:zebra-edits

Conversation

@glennj
Copy link
Copy Markdown
Contributor

@glennj glennj commented Jun 25, 2024

From the forum.

@glennj glennj requested a review from a team as a code owner June 25, 2024 01:32
@glennj glennj added the x:rep/small Small amount of reputation label Jun 25, 2024
@@ -1,7 +1,7 @@
# Introduction

The Zebra Puzzle is a famous logic puzzle in which there are five houses, each painted a different color.
Copy link
Copy Markdown
Member

@kahgoh kahgoh Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might help to state that this is a modified version of the Zebra Puzzle (or something similar along those lines). A student who Googles "Zebra Puzzle" will likely find the previous version. For example, the previous version are on Wikipedia and The Dinner Table.

Perhaps, something along the lines of:

The Zebra Puzzle is a famous logic puzzle in which there are five houses.
In this version, each house is painted a different color, ....

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exercise does have a source URL and the name isn't changed. Are you concerned that students will be confused that this version is different from another version?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was thinking it might be confusing for the student if they see another version, especially as the source URL points to Wikipedia, which describes the puzzle with the previous wording. Although the Wikiepdia page also does state that there are different versions of the puzzle, I think stating it will help to reduce that confusion.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that students will see the versions differ if they compare the exercises. I don't think that needs pointing out. If they compare versions and notice they are different, I think most people will realize Exercism opted for different specifics for some reason. I don't especially think we need to spell that out in the instructions.

I'm curious to hear what others think!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen many variations used when researching the exercise, so I think it's fine to have us use a variation.

@IsaacG IsaacG merged commit b74c895 into exercism:main Jun 25, 2024
@glennj glennj deleted the zebra-edits branch June 25, 2024 12:37
Comment thread exercises/zebra-puzzle/instructions.md
kahgoh added a commit to kahgoh/exercism-vlang that referenced this pull request Apr 7, 2026
kahgoh added a commit to exercism/vlang that referenced this pull request Apr 7, 2026
* Check if list exists in map before appending

Fixes an issue in grade school and zebra puzzle where items were being
appended to an uninitialized list. In the latest unreleased version of
V, this was causing the list to remain empty.

* Apply formatter to zebra puzzle example

This is to fix formatting.

* Use int instead of u8 in zebra puzzle example

This is to simplify the example and reduce the amount of casting needed.

* Update activities in Zebra puzzle example

This is to match changes made to exercism/problem-specifications#2459.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:rep/small Small amount of reputation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants