Skip to content

Remove track specific wording from triangle readme#275

Merged
Cohen-Carlisle merged 1 commit intoexercism:masterfrom
tgecho:patch-2
Jun 18, 2016
Merged

Remove track specific wording from triangle readme#275
Cohen-Carlisle merged 1 commit intoexercism:masterfrom
tgecho:patch-2

Conversation

@tgecho
Copy link
Copy Markdown
Contributor

@tgecho tgecho commented Jun 18, 2016

We had a confused user of the Elm track because elm-test does not have a "skip" concept (exercism/elm#66). It seems to me that this sort of instruction would be more suitable as a comment in the test file for now.

The other option might be just qualify this note a bit.

@Cohen-Carlisle
Copy link
Copy Markdown
Member

👍

@petertseng
Copy link
Copy Markdown
Member

petertseng commented Jun 18, 2016

And in fact any languages that do have skips are probably usingn that approach in all their exercises, which means it might best go somewhere global rather than per-exercise.

As just one example see how Ruby put their skip documentation into https://github.com/exercism/xruby/blob/master/docs/TESTS.md

So seems good to merge this!

@Cohen-Carlisle Cohen-Carlisle merged commit cdfb4a2 into exercism:master Jun 18, 2016
@tgecho
Copy link
Copy Markdown
Contributor Author

tgecho commented Jun 18, 2016

Thanks! 👍

emcoding pushed a commit that referenced this pull request Nov 19, 2018
emcoding pushed a commit that referenced this pull request Nov 19, 2018
binary: Add invalid edge case tests. Closes #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants