sublist: Warn about comparing values#319
Merged
petertseng merged 1 commit intoexercism:masterfrom Aug 30, 2016
petertseng:sublist-warning
Merged
sublist: Warn about comparing values#319petertseng merged 1 commit intoexercism:masterfrom petertseng:sublist-warning
petertseng merged 1 commit intoexercism:masterfrom
petertseng:sublist-warning
Conversation
In some languages, it is necesary to ensure that no pair of the four possible expected values are equal. Otherwise, an essentially-empty implementation may pass tests without actually doing any useful work. Example: exercism/python#342 This same warning was added to the triangle JSON file in #311.
Member
|
Looks good to me. |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
* Updated tests and example `Bst#each` should return an enumerator if it doesn't get a block. Added a test to ensure that it does and that the returned enumerator behaves properly. Added a version constant for the tests. Updated `example.rb` to pass the updated tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some languages, it is necesary to ensure that no pair of the four
possible expected values are equal. Otherwise, an essentially-empty
implementation may pass tests without actually doing any useful work.
Example: exercism/python#342
This same warning was added to the triangle JSON file in #311.