pangram: Add case-insensitive test#439
Conversation
| "expected": false | ||
| }, | ||
| { | ||
| "description": "test that count is case-insensitive", |
There was a problem hiding this comment.
This needs a better description of what we're testing for.
case insensitivity is already covered by: "Five quacking Zephyrs jolt my wax bed."
There was a problem hiding this comment.
How about: "upper and lower case versions of the same character should not be counted separately"
Edit: I think there's a better description than that, I just don't know what it is right now.
|
@behrtam Here also a more descriptive commit message would be really helpful. |
behrtam
force-pushed
the
add-test-pangram
branch
3 times, most recently
from
a421ffe to
7e21769
Compare
Insti
left a comment
Insti
left a comment
There was a problem hiding this comment.
The test description comments from my previous review have not been addressed.
Any new ideas or someone else? |
|
No new ideas, "upper and lower case versions of the same character should not be counted separately" is the best I have for now. |
|
+1 to "upper and lower case versions of the same character should not be counted separately"; it's a little verbose, but perfectly clear. |
The new test cases verifiys that the characters are counted case-insensitive. Resolves: exercism#266
behrtam
force-pushed
the
add-test-pangram
branch
from
7e21769 to
dc928a8
Compare
|
Perfect, thanks both of you. Than I guess we are good to go. |
|
Thanks @behrtam ❤️ |
4 participants
see #266