minesweeper: remove number from input, add mines#456
Merged
petertseng merged 1 commit intoexercism:masterfrom Nov 29, 2016
petertseng:minesweeper
Merged
minesweeper: remove number from input, add mines#456petertseng merged 1 commit intoexercism:masterfrom petertseng:minesweeper
petertseng merged 1 commit intoexercism:masterfrom
petertseng:minesweeper
Conversation
an input containing only "8" implies that the student solution is supposed to read a board with numbers and fill in the mines, which is contrary to all other tests (read a board with mines, fill in the numbers)
Member
Author
|
Found with: require 'json'
json = JSON.parse(IO.read('canonical-data.json'))
json['cases'].each { |c|
input = c['input']
output = c['expected']
clean = output.map { |l| l.gsub(/\d/, ' ') }
raise "Nope on #{c}, got #{clean}" if clean != input
}https://github.com/petertseng/x-common/blob/verify/exercises/minesweeper/verify.rb |
Contributor
|
That was a good catch. Is the verify script something that could be added to the CI build? |
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an input containing only "8" implies that the student solution is
supposed to read a board with numbers and fill in the mines, which is
contrary to all other tests (read a board with mines, fill in the
numbers)