hello-world: clarify "says"#614
Merged
petertseng merged 1 commit intoexercism:masterfrom Feb 28, 2017
Merged
Conversation
Contributor
|
+1 this. I think there are other exercises that could also benefit from the same adjustment ( |
stkent
approved these changes
Feb 27, 2017
ErikSchierboom
approved these changes
Feb 28, 2017
petertseng
approved these changes
Feb 28, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
Thanks. Yeah, we should have paid attention to exercism/exercism#2746 when doing #544.
Just as you edited the PR title to include hello-world, going to amend the commit message to also do so.
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
generator: disable old example loc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it could be worthwhile to clarify what "says" means in the exercise description. Often, "Hello, World!" programs print
Hello, World!to the screen, but the Exercism exercises I've seen instead ask for a function that returns the stringHello, World!.Because "says" could sound like it's figuratively referring to printing to the screen, and because a learner familiar with "Hello, World!" programs might expect to write a program that prints
Hello, World!to the screen, I think "returns the string" might be clearer here.Thoughts?