allergies: Make exercise schema-compliant#628
allergies: Make exercise schema-compliant#628kotp merged 2 commits intoexercism:masterfrom rbasso:allergies-schema
Conversation
| "cases": [ | ||
| { | ||
| "description": "allergicTo", | ||
| "comments": [ |
There was a problem hiding this comment.
Am I misreading the spec, or doesn't comments go at the top level?
"canonicalData":
{ "description": "This is the top-level file structure"
, "type" : "object"
, "required" : ["exercise" , "version", "cases"]
, "properties" :
{ "exercise" : { "$ref": "#/definitions/exercise" }
, "version" : { "$ref": "#/definitions/version" }
, "comments" : { "$ref": "#/definitions/comments" }
, "cases" : { "$ref": "#/definitions/testGroup" }
}
, "additionalProperties": false
},
There was a problem hiding this comment.
We can have comments in the top level, in a test group, or inside a test, so that people can keep them where they fit better. In this case, it is in the test group because it pertains just that group of test.
|
@rbasso is this diving into the "more than just formatting and compliance"? |
|
At first glance it appears it is grouping expectations in a different way. I will look closer though. |
|
I was forced to move the |
|
That now makes sense. |
Related to #625.