leap: Make exercise schema-compliant#633
Conversation
| "comments": [ | ||
| "Given a Gregorian calendar year, indicate whether it is a leap year." | ||
| ], | ||
|
|
There was a problem hiding this comment.
This comment may be nice, but it was not in the original test suite and also is not needed for compliance, so maybe it should not be part of this PR.
If you think it must be here, a third commit would be perfect for it.
| "cases": [ | ||
| { | ||
| "description": "year not divisible by 4: common year", | ||
| "property": "notLeap", |
There was a problem hiding this comment.
About isLeap and notLeap
All the tests in this test suite use exactly the same test logic, only changing the test data, so they should have the same property value. isLeapYearand leapYear are good candidates
rbasso
left a comment
rbasso
left a comment
There was a problem hiding this comment.
Thanks for opening the PR. 👍
The idea when I suggested separating in two commits was to be able to see where the data changed for an easier review, but the first commit seems to change data and also formatting.
Anyway, I visually checked it and it seems that the data has not changed. 👍
|
Oh, ok -- hopefully this is more what you wanted. |
2 participants
Related to #625.