book-store: Make exercise schema-compliant

[rpottsoh]

Related to #625

[rbasso]

Thanks for opening this PR! 👍

I didn't check the test data, because the first commit changes data and formatting at the same time, so it is too hard to see if anything was changed accidentally.

[rbasso]

Here there was a description just inside the total key:

returns the total basket price after applying best discount

The way to deal with that in the new schema is to create a test group with that description, so that we don't loose/change any information.

{
  "description": "...",
  "cases": [
    ...
  ]
}

[rpottsoh]

@rbasso I was a little confused about how to deal with that description. I added it back in to the second commit at the tail end of comment at the beginning.

[rbasso]

Oh, sorry. I didn't see that. 👍

[rpottsoh]

@rbasso is that acceptable?
I am not having much luck following your suggestion to add a description. What I add either doesn't satisfy the schema or fails JSONLint.

[rbasso]

I guess you chose a hard one to start. 😄

Take a look this link. This is how I would rewrite the test suite, trying to keep the original data organization (before fixing formatting)

Anyway, I guess it is also ok the way it is, because there is just one group, so there will be no confusion.

[rpottsoh]

Hey, what can I say? 😄 Thanks for the link. I like what you did there. I am going to update the PR.

[rpottsoh]

@rbasso fixed the second commit. Thanks for your help.

[rpottsoh]

@rbasso you have been a json machine today! Thanks! Take a break. 😄

[rbasso]

@rbasso you have been a json machine today! Thanks! Take a break. 😄

Already stopped. I was in a commit-spree and I didn't see the time passing. 😁

[rbasso]

The indentation is a little irregular at the test data (1 space vs 2-spaces in the rest of the file) but that doesn't hinder readability, so it doesn't need to be changed.

The commit history got a little messed up now. Do you want to change it or should I squash-merge it?

[rpottsoh]

Go and squash merge, the overall content of the file is unchanged from the original. Thanks again. Sent from my android device.