trinary: Make exercise schema-compliant#645
trinary: Make exercise schema-compliant#645kotp merged 2 commits intoexercism:masterfrom rbasso:trinary-schema
Conversation
| "cases": [ | ||
| { | ||
| "description": "trinary 1 is decimal 1", | ||
| "property": "toDecimal", |
There was a problem hiding this comment.
Shouldn't the property simply be "Decimal" or even "Base10"?
There was a problem hiding this comment.
In the original file, the test group was named to_decimal, so I just adapted it to make it a valid property according to the JSON Schema: toDecimal.
IMHO, decimal, toDecimal and base10 do not capture what it means. The output is a number here, not a string, so there is no sense talking about what is its base. It is represented in JSON as a decimal, but that is just a convenience for visualization.
if I where to choose I name, it would probably be fromTrinary.
Summarizing, I just tried to minimize the number of changes. But I don't think the name is good by any criteria.
|
As an exercise that will soon be deprecated, this is definitely good enough. |
2 participants
Related to #625.