queen-attack: Make exercise schema-compliant#655
queen-attack: Make exercise schema-compliant#655rbasso merged 2 commits intoexercism:masterfrom rbasso:queen-attack-schema
Conversation
| "queen": { | ||
| "position": "(-2,2)" | ||
| }, | ||
| "expected": -1 |
There was a problem hiding this comment.
Shouldn't -1 be replaced with an error object? If so, the description in the "comments" key should also be updated.
There was a problem hiding this comment.
I agree you you. It should be an error, or maybe null.
A lot of other test suites have exactly the same problem, but in #625 we are just making changes that do not affect the contents of the test suite, only changes in structure (with some unavoidable small exceptions), so that they formally complies with the JSON schema.
Maybe we should open a new force after finishing this one to make sure that all the test suite follow the best practices and error encoding conventions. For now, I would really like to avoid it, because even the mechanical work of adapting them to the new schema is already taking a lot of time. 😩
There was a problem hiding this comment.
I see. Let's do what you suggested then.
There was a problem hiding this comment.
BTW, thanks for reviewing all this.
difference-of-squares: Update test cases
2 participants
Related to #625.