sublist: Make exercise schema-compliant#705
sublist: Make exercise schema-compliant#705rbasso merged 3 commits intoexercism:masterfrom rbasso:sublist-schema
Conversation
|
Surprise! expectation -> expected please. The only file to do that. Well, okay, I guess |
petertseng
left a comment
There was a problem hiding this comment.
well I'll tell you what, if you really want to stick with expectation and change it later, you still have my support
|
I'm considering changing to |
Good!
Seems good too! You also did it in rotational-cipher so why not here too! |
Change key names: - 'expectation' -> 'expected', which is an informal standard - 'list_one' -> 'listOne' - 'list_two' -> 'listTwo' These last two changes are to follow the Google JSON Style Guide, which recommends camelCase for key names.
|
Updated! |
|
The last commit (the only one hard to review) should be just formatting. |
|
I review commits that claim to be formatting-only with Plus a small script to fetch arbitrary PRs: #!/bin/sh
# remote of current branch is...
remotebranch=$(git rev-parse --abbrev-ref --symbolic-full-name @{u})
remote=$(echo "$remotebranch" | cut -d/ -f1)
echo "remote: $remote"
if [ $# -lt 2 ]; then
echo "usage: $0 PR localbranch"
exit 1
fi
git fetch $remote refs/pull/$1/head:$2
|
|
Thanks! I'll try that later. |
Add default introductory code example
Related to #625.