bowling: Make descriptions consistent#832
Merged
stkent merged 1 commit intoexercism:masterfrom Jun 18, 2017
Merged
Conversation
Member
yes because https://github.com/exercism/x-common#patch-version-changes says "Changing descriptions or comments." and this does that. no distinction is made whether they are cosmetic changes these changes look good, thanks. |
Make the usage of _can not_ and _cannot_ consistent throughout the file. Also add a missing `more` in one of the descriptions.
Contributor
Author
|
@petertseng awesome! done 👍. |
petertseng
approved these changes
Jun 18, 2017
Insti
approved these changes
Jun 18, 2017
Insti
changed the title
stkent
approved these changes
Jun 18, 2017
Contributor
|
Nice changes, thanks! |
kotp
added a commit
to exercism/ruby
that referenced
this pull request
Aug 27, 2017
emcoding
pushed a commit
that referenced
this pull request
Nov 19, 2018
* affine-cipher: built generator; generated test; added BookKeeping to solution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the usage of can not and cannot consistent throughout the file. Also add a missing
morein one of the descriptions.Since these changes are mostly cosmetic, I am not sure if a patch-level bump to the
versionkey is required here. Please tell me if that is the case, so I can update it accordingly.