crypto-square: Don't test intermediate functions#922
crypto-square: Don't test intermediate functions#922ErikSchierboom merged 1 commit intoexercism:masterfrom nholden:fix-crypto-canonical-data
Conversation
We want to remove tests of intermediate functions in crypto-square that test implementation details per these issues: - exercism/discussions#41 - exercism/ruby#422 This rewrites the canonical data for crypto-square so that we're only testing the expected value of the final "ciphertext" property and none of the intermediate properties.
|
Here's one more relevant issue: #750 |
| "cases": [ | ||
| { | ||
| "description": "the spaces and punctuation are removed from the English text and the message is downcased", | ||
| "cases": [ |
There was a problem hiding this comment.
Should we still be using sub cases keys if we are only testing one property?
There was a problem hiding this comment.
Hmm, good question! I see in the README:
Test cases can be arbitrarily grouped with a description to make organization easier.
These cases all have to do with "normalizing" text, while the next group of cases deal with "chunking" and ordering letters. I'm not sure whether or not that "makes organization easier." I'm happy to dump the sub cases or save that re-organization for when we add new tests.
There was a problem hiding this comment.
I'm not sure what the answer is either, I'm OK with leaving it as it is for now as the logical separation is still there even if the property name has changed.
If it ends up breaking someone's test generator I'm sure they'll submit a PR to fix it.
|
Removing the intermediate functions is good 👍 There are probably more test cases that need to be added, but they can be included by a separate PR once we work out what they are. |
|
Thanks @nholden ! |
3 participants
We want to remove tests of intermediate functions in crypto-square that pry into implementation details per these issues:
This rewrites the canonical data for crypto-square so that we're only testing the expected value of the final "ciphertext" property and none of the intermediate properties.