nucleotide-count: Adding a single character case#951
Conversation
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
Absolutely. I agree.
I note that if I write the commit message I must write "Add" not "Adding", but (because I can edit the commit message) that does not stop me from Approving (in the GitHub sense).
| "T": 0 | ||
| } | ||
| }, | ||
| { |
There was a problem hiding this comment.
presently the only description that ends in punctuation, until other descriptions are changed. This means that inevitably this will cause to discuss:
- whether the descriptions in this file should, in general, end in punctuation
- is the (temporary, right?) inconsistency OK
There was a problem hiding this comment.
My vote is for consistency. Punctuation should be a separate PR, or at the very least a separate commit.
Insti
left a comment
Insti
left a comment
There was a problem hiding this comment.
Remove the period in the description for consistency as discussed above.
Other than that I think this is good. 👍
Vankog
force-pushed
the
nucleotide-count_add_single_char_case
branch
from
0daf900 to
236c488
Compare
|
done and squashed while rebasing |
Vankog
force-pushed
the
nucleotide-count_add_single_char_case
branch
from
236c488 to
f286161
Compare
|
I could merge this but I think it is better to let @Insti approve the changes first. |
|
Thanks @Vankog ❤️ |
…case nucleotide-count: fix wrong order introduced in #951
Relevant PRs: - exercism/problem-specifications#666 - exercism/problem-specifications#951 - exercism/problem-specifications#957 - exercism/problem-specifications#1126 Basically renamed the old test cases and the process function.
4 participants
Splitting #895 into single PRs.
Adding a single char input case for better TDD progression as agreed upon by @petertseng (#895 (review)) and @Insti (#895 (comment))