pangram: add a case with a perfect pangram for better TDD progression#952
Merged
petertseng merged 1 commit intoexercism:masterfrom Oct 15, 2017
Merged
Conversation
petertseng
approved these changes
Oct 13, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
Same comment as in the other PR (that I would write "add" not "adding", but it doesn't stop me from Approving)
petertseng
reviewed
Oct 13, 2017
| "input": "", | ||
| "expected": false | ||
| }, | ||
| { |
Member
There was a problem hiding this comment.
presently the only description that ends in punctuation, until other descriptions are changed. This means that inevitably this will cause to discuss:
- whether the descriptions in this file should, in general, end in punctuation
- is the (temporary, right?) inconsistency OK
Contributor
There was a problem hiding this comment.
The ocaml test generator uses the description as the name of the test. Not a big deal, but I'd prefer no full stop.
Insti
suggested changes
Oct 14, 2017
Contributor
Insti
left a comment
Insti
left a comment
There was a problem hiding this comment.
I like the added test 👍
Just the description punctuation to resolve.
Vankog
added a commit
to Vankog/problem-specifications
that referenced
this pull request
Oct 14, 2017
Vankog
force-pushed
the
pangram_add_perfect_pangram_case
branch
from
a9f110e to
5c75059
Compare
Contributor
Author
|
done and squashed while rebasing. |
Insti
approved these changes
Oct 14, 2017
Contributor
|
Great. Looks good. |
petertseng
approved these changes
Oct 15, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
think there's no controversy here. let's merge.
petertseng
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #893 into single PRs.
Adding case with a "perfect pangram" for better TDD progression.
As suggested by
@petertseng (https://github.com/exercism/problem-specifications/pull/893/files#r144452355) and@Insti (#893 (comment))Edit: The suggestion from @petertseng above does not count towards this, because I misunderstood it for another issue.