pangram: fix duplicative case for a missing 'x'#958
Merged
petertseng merged 1 commit intoexercism:masterfrom Oct 18, 2017
Merged
Conversation
Currently two cases check for a missing 'x'. This is changed to 'h' to test more thoroughly. exercism#958
Vankog
force-pushed
the
pangram-fix_duplicative_case_for_a_missing_x
branch
from
c262cc1 to
f4aabe2
Compare
rpottsoh
approved these changes
Oct 16, 2017
ErikSchierboom
approved these changes
Oct 17, 2017
Contributor
Author
|
@Insti well, the big ones are discussions after all with provided proposals to discuss. I still think it was the right attempt to at least talk about it in the whole context. Although, it got really convoluted over time. ^^ |
petertseng
approved these changes
Oct 18, 2017
Member
petertseng
left a comment
petertseng
left a comment
There was a problem hiding this comment.
seems we've given this the time it needs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splitting #893 into multiple PRs.
Currently two cases check for a missing 'x'. This does not make much sense and the second case was changed to test for a missing 'h' instead, while 'h' was chosen randomly.
This improves the TDD progression and forces the user to check for more than just 'x'.