Feature/add exercise isbn verifier#1143
Merged
cmccandless merged 10 commits intoexercism:masterfrom Jan 15, 2018
Merged
Conversation
…' into feature/add-exercise-isbn-verifier
* removed isbn-13 stuff
pheanex
force-pushed
the
feature/add-exercise-isbn-verifier
branch
from
91a6138 to
b1d6e15
Compare
cmccandless
suggested changes
Jan 9, 2018
| "type_conversion", | ||
| "conditionals", | ||
| "strings", | ||
| "arrays", |
Contributor
There was a problem hiding this comment.
Not sure that arrays is a relevant topic for this one (might be for certain solution implementations, but not integral to the problem definition).
| from isbn_verifier import verify | ||
|
|
||
|
|
||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v2.0.0 |
Contributor
There was a problem hiding this comment.
Apologies for the delay in reviewing, but since this was written the canonical data has been updated. Can you please update the tests to v2.2.0?
cmccandless
approved these changes
Jan 12, 2018
Contributor
|
@pheanex Merged; thanks! |
Contributor
Author
|
Thank you for reviewing @cmccandless 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1142