[WIP] Full-scale test update #1262
Conversation
* More concise assertions * More meaningful test method names * Remove property `name` from `Scale` class and related test cases * Remove brokeninterval test case
* Remove attribute `name` * Rename `pattern` to intervals * Add necessary property `pitches`
|
@cmccandless While I'm working on updating tests, I've encountered two exercises that differ quite a lot from canonical data:
|
Yes, I believe adopting a similar style to
Yes, I recall commenting in #773 that canonical data was being implemented; I'm not sure why I didn't push then to wait until the data was merged to problem-specifications. I think a new PR would be the best practice. I will review this PR once you've made the changes to |
|
@cmccandless Separating PRs would be a better idea, and thank you for pointing this out. I'll keep this PR as a checklist, and close it when everything is done. |
|
I think we're done with this wave of tests updates (except react for callback issues). |
2 participants
Updates with nothing changed, such as applying new input policy, correcting naming styles, etc:
Updates with changes to tests: