saddle-points: Add tests for non-square matrices#1449
saddle-points: Add tests for non-square matrices#1449cmccandless merged 2 commits intoexercism:masterfrom
Conversation
| def test_matrix_with_one_elem_has_single_saddle_point(self): | ||
| matrix = [[1]] | ||
| self.assertEqual(saddle_points(matrix), set([(0, 0)])) | ||
|
|
There was a problem hiding this comment.
This test is not canonical, but I think it's a good one. Might not be a bad idea to create another PR in problem-specifications to add it there too, but I don't think this PR needs to be held up waiting on that.
There was a problem hiding this comment.
@cmccandless Oh. Yes. I forgot to remove that test. I had initially written it but then considered that the the issue was about NxM and it wasn't directly related so I didn't want to add extraneous tests to it.
I guess I should've asked first whether to include it or not but decided not to and forgot to remove it in this pull request.
Now that it has been merged... Should I create a new pull request in canonical with the same version number explaining that I'm adding that single element test or what should I do?
There was a problem hiding this comment.
@Alexhans At this point, I would suggest making a new pull request in canonical, bumping the version number to 1.4.0 (because minor number is changed whenever tests are added/removed) and adding the 1x1 test.
|
Merged; thanks for working on this! |
2 participants
The saddle-points exercise made no indication that it was just for NxN matrices but tests for NxM matrices were non-existent.
This pull request depends on the successful merge of exercism/problem-specifications/pull/1288