Added affine-cipher by tintinthong · Pull Request #123 · exercism/r

tintinthong · 2019-07-31T19:48:11Z

README can be improved. Need feedback if possible.

Put difficulty as 5 since this question is math heavy. Do not know whether scale is 1-10 (i meant for this scale) or 1-5. All other questions below difficulty of 5 so can't judge.

Here is the [problem specs] (https://github.com/exercism/problem-specifications/blob/master/exercises/affine-cipher/description.md)

…to be there

…o problem.

…sing uuid package (not sure how uuids are generated normally)

1)Being unlocked_by "raindrops" 2)Adding source to README 3)Fixing example function as to not use `cat()` 4) Styling all files 5) Removing lintr.R 6)Changing string to vector of string as to not use `cat()`

2. chhanging condition to replace_number

# Conflicts: # exercises/fizz-buzz/README.md

…k any other question is similar.

lintr-bot · 2019-07-31T19:56:04Z

exercises/affine-cipher/example.R:17:1: style: lines should not be more than 80 characters.

  return(paste(letters[ ((a * (match(strsplit(tolower(gsub(" ", "", message)), "")[[1]], letters) - 1) + b) %% m) + 1], collapse = ""))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/example.R:48:1: style: lines should not be more than 80 characters.

  return(paste(letters[((mmi(a, m) * ((match(strsplit(gsub(" ", "", encryption), "")[[1]], letters) - 1) - b)) %% m) + 1], collapse = ""))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/test_affine-cipher.R:24:1: style: lines should not be more than 80 characters.

  expect_identical(decrypt("kqlfd jzvgy tpaet icdhm rtwly kqlon ubstx", 19, 13), "thequickbrownfoxjumpsoverthelazydog")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/test_affine-cipher.R:29:1: style: lines should not be more than 80 characters.

  expect_identical(decrypt("kqlfd jzvgy tpaet icdhm rtwly kqlon ubstx", 19, 13), "thequickbrownfoxjumpsoverthelazydog")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

lintr-bot · 2019-07-31T19:56:15Z

exercises/affine-cipher/example.R:17:1: style: lines should not be more than 80 characters.

  return(paste(letters[ ((a * (match(strsplit(tolower(gsub(" ", "", message)), "")[[1]], letters) - 1) + b) %% m) + 1], collapse = ""))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/example.R:48:1: style: lines should not be more than 80 characters.

  return(paste(letters[((mmi(a, m) * ((match(strsplit(gsub(" ", "", encryption), "")[[1]], letters) - 1) - b)) %% m) + 1], collapse = ""))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/test_affine-cipher.R:24:1: style: lines should not be more than 80 characters.

  expect_identical(decrypt("kqlfd jzvgy tpaet icdhm rtwly kqlon ubstx", 19, 13), "thequickbrownfoxjumpsoverthelazydog")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/test_affine-cipher.R:29:1: style: lines should not be more than 80 characters.

  expect_identical(decrypt("kqlfd jzvgy tpaet icdhm rtwly kqlon ubstx", 19, 13), "thequickbrownfoxjumpsoverthelazydog")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

lintr-bot · 2019-07-31T19:56:23Z

exercises/affine-cipher/example.R:17:1: style: lines should not be more than 80 characters.

  return(paste(letters[ ((a * (match(strsplit(tolower(gsub(" ", "", message)), "")[[1]], letters) - 1) + b) %% m) + 1], collapse = ""))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/example.R:48:1: style: lines should not be more than 80 characters.

  return(paste(letters[((mmi(a, m) * ((match(strsplit(gsub(" ", "", encryption), "")[[1]], letters) - 1) - b)) %% m) + 1], collapse = ""))
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/test_affine-cipher.R:24:1: style: lines should not be more than 80 characters.

  expect_identical(decrypt("kqlfd jzvgy tpaet icdhm rtwly kqlon ubstx", 19, 13), "thequickbrownfoxjumpsoverthelazydog")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

exercises/affine-cipher/test_affine-cipher.R:29:1: style: lines should not be more than 80 characters.

  expect_identical(decrypt("kqlfd jzvgy tpaet icdhm rtwly kqlon ubstx", 19, 13), "thequickbrownfoxjumpsoverthelazydog")
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

katrinleinweber · 2019-08-01T10:30:37Z

Hello again and thanks for another contribution :-)

As you see, a lot of left-over commits from #122 are included here, so let's first remove 73af394 to 1fc4edb. Assuming your git remote --verbose contains origin https://github.com/tintinthong/r and upstream https://github.com/exercism/r (fetch), please try in your command line:

git fetch --all to see the existing updates on GitHub
git checkout -b affine-cipher-2 upstream/master to start a fresh branch for this PR
git cherry-pick 5803eb5 && git cherry-pick 1865352 to transfer this PR's main commits
git push --force-with-lease -u origin affine-cipher to overwrite this PR's "dirty" branch

If you only edited in GitHub's web interface so far, please see the links under https://github.com/exercism/r#writing-a-pull-request.

If you're unsure about that, feel free ask me about any of these steps or give me the green light to clean up.

tintinthong · 2019-08-06T17:40:46Z

Hello again and thanks for another contribution :-)

As you see, a lot of left-over commits from #122 are included here, so let's first remove 73af394 to 1fc4edb. Assuming your git remote --verbose contains origin https://github.com/tintinthong/r and upstream https://github.com/exercism/r (fetch), please try in your command line:

git fetch --all to see the existing updates on GitHub

git checkout -b affine-cipher-2 upstream/master to start a fresh branch for this PR

git cherry-pick 5803eb5 && git cherry-pick 1865352 to transfer this PR's main commits

git push --force-with-lease -u origin affine-cipher to overwrite this PR's "dirty" branch

If you only edited in GitHub's web interface so far, please see the links under https://github.com/exercism/r#writing-a-pull-request.

If you're unsure about that, feel free ask me about any of these steps or give me the green light to clean up.

Hi sorry. have been busy with work. I will try to solve it 😬

tintinthong · 2019-08-06T19:26:37Z

Hello again and thanks for another contribution :-)

As you see, a lot of left-over commits from #122 are included here, so let's first remove 73af394 to 1fc4edb. Assuming your git remote --verbose contains origin https://github.com/tintinthong/r and upstream https://github.com/exercism/r (fetch), please try in your command line:

git fetch --all to see the existing updates on GitHub

git checkout -b affine-cipher-2 upstream/master to start a fresh branch for this PR

git cherry-pick 5803eb5 && git cherry-pick 1865352 to transfer this PR's main commits

git push --force-with-lease -u origin affine-cipher to overwrite this PR's "dirty" branch

If you only edited in GitHub's web interface so far, please see the links under https://github.com/exercism/r#writing-a-pull-request.

If you're unsure about that, feel free ask me about any of these steps or give me the green light to clean up.

@katrinleinweber I just made a new pull request. If no problems I'd like to close this pull request and work on my new branch affin-cipher-fix

tintinthong added 15 commits July 21, 2019 00:20

Adding fizz-buzz file

73af394

Add fizz buzz question, answer and tests

f84133a

Removed clutter inside main question function -- it was not supposed …

1875be5

…to be there

Removed solution from testing file -- silly. Used cat() as solution t…

d4e0cd6

…o problem.

Fix linting errors by lintr-bot.

64d3bab

Fix linting errors exercism#2

6382840

Edited config.json to include fizz-buzz slug. Generated random uuid u…

3622f15

…sing uuid package (not sure how uuids are generated normally)

Commit

339c7d3

1)Being unlocked_by "raindrops" 2)Adding source to README 3)Fixing example function as to not use `cat()` 4) Styling all files 5) Removing lintr.R 6)Changing string to vector of string as to not use `cat()`

Forgot changes to README

0e7fb86

1. Fixing source in README.md

cd16bcd

2. chhanging condition to replace_number

Fixed /D for actuoal source

b9b0d06

Revert deletion rosetta code and code golf links

e615ccb

Merge branch 'master' of https://github.com/tintinthong/r

1fc4edb

# Conflicts: # exercises/fizz-buzz/README.md

added affine-cipher

5803eb5

Changes to config file. Math heavy so put difficult of 5. Do not thin…

1865352

…k any other question is similar.

tintinthong mentioned this pull request Aug 6, 2019

Affin cipher fix #125

Open

tintinthong closed this Aug 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Added affine-cipher#123

Added affine-cipher#123
tintinthong wants to merge 15 commits intoexercism:masterfrom
tintinthong:affine-cipher

tintinthong commented Jul 31, 2019

Uh oh!

lintr-bot commented Jul 31, 2019

Uh oh!

lintr-bot commented Jul 31, 2019

Uh oh!

lintr-bot commented Jul 31, 2019

Uh oh!

katrinleinweber commented Aug 1, 2019

Uh oh!

tintinthong commented Aug 6, 2019

Uh oh!

tintinthong commented Aug 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

tintinthong commented Jul 31, 2019

Uh oh!

lintr-bot commented Jul 31, 2019

Uh oh!

lintr-bot commented Jul 31, 2019

Uh oh!

lintr-bot commented Jul 31, 2019

Uh oh!

katrinleinweber commented Aug 1, 2019

Uh oh!

tintinthong commented Aug 6, 2019

Uh oh!

tintinthong commented Aug 6, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants