Conversation
BNAndras
added
x:rep/large
There was a problem hiding this comment.
I'd like to ignore the JS files given they're just the transpiled ReScript code. It'd likely be confusing to have two copies of the test suite. This keeps it simple
| "rescript-test": "^8.0.0", | ||
| "toml": "^3.0.0" | ||
| }, | ||
| "scripts": { |
There was a problem hiding this comment.
I updated the scripts here since I was having trouble running the test command within the exercise folder. That's where students will be running npm run test or exercism test locally so we should make it work cleanly cross-platform. I was also having some trouble where subsequent npm run test calls were using a cached copy of my solution so I was passing tests with my failing code or failing tests with my passing code.
There was a problem hiding this comment.
I noticed there were two empty lines generated at the end of the file. The tradition for Unix systems is one empty line to mark the end of the file so we might as well do that.
There was a problem hiding this comment.
let me add this to an upcoming PR. I will address it at the same time as copying over .resi files etc
2 participants
No description provided.