[Isogram] Improvements required

[Insti]

• 1 Method should be called isogram?
• 2 Asserts have no failure messages.
• 3 The first string tested "duplicates" is deceptive. (update to "no duplicates")
• 4 Whitespace/hypens not excluded by documentation.
• 5 Test cases contain non-ascii characters
• 6 Test cases should be named for the property they are testing.
• 7 Should we add a test that the argument string is not modified by the method?

Some of these things will require updating the data in x-common.
See also: exercism/problem-specifications#410

[Insti]

7 Should we add a test that the argument string is not modified by the method?

No. This is an implementation detail, it is not mentioned in the Readme and is something that can be covered during reviews.

[Insti]

5 Test cases contain non-ascii characters

Fixed by: exercism/problem-specifications#433

[Insti]

6 Test cases should be named for the property they are testing.

exercism/problem-specifications#433 also adds descriptions that can be used to generate better test names.

[Insti]

3 The first string tested "duplicates" is deceptive. (update to "no duplicates")

Fixed in x-common

[Insti]

6 Test cases should be named for the property they are testing.

Fixed by #500

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.